Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unsized consts with type str in v0 symbol mangling #130344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle unsized consts with type str in v0 symbol mangling #130344

wants to merge 1 commit into from
+51 −32

Conversation

Jaic1
Copy link
Contributor

@Jaic1 Jaic1 commented Sep 14, 2024

This PR fixes #116303 by handling consts with type str in v0 symbol mangling as partial support for unsized consts.

This PR is related to #![feature(adt_const_params)] (#95174) and #![feature(unsized_const_params)] (#128028).

r? @BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 14, 2024
@BoxyUwU
Copy link
Member

BoxyUwU commented Sep 19, 2024

Can you also squash all of your commits into one? I think this is good to merge afterwards :)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

Assignees

@BoxyUwU BoxyUwU

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: symbol_names: unsupported constant of type 'str', -Cinstrument-coverage
4 participants
@Jaic1 @BoxyUwU @rust-log-analyzer @rustbot